Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JetBrains warnings and update ReSharper version to 2024.3.4 #679

Conversation

tjementum
Copy link
Member

@tjementum tjementum commented Jan 25, 2025

Summary & Motivation

After upgrading Rider and ReSharper to JetBrains 2024.3.4, new warnings started appearing in the editor, specifically recommending the use of CancellationToken.None instead of new CancellationToken().

Warnings have been fixed, and the jetbrains.resharper.globaltools version in the global.json .NET tooling file has been updated to 2024.3.4, ensuring consistency between the build server and local development environments.

Downstream Projects

Please run the code-inspections CLI command to detect any warnings and fix these before continuing.

Checklist

  • I have added tests, or done manual regression tests
  • I have updated the documentation, if necessary

@tjementum tjementum added the Enhancement New feature or request label Jan 25, 2025
@tjementum tjementum self-assigned this Jan 25, 2025
Copy link

linear bot commented Jan 25, 2025

@tjementum tjementum merged commit 0cdb348 into main Jan 25, 2025
17 checks passed
@tjementum tjementum deleted the pp-311-rider-shows-warnings-after-upgrading-to-jetbrains-202434 branch January 25, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant