New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logout issue on pages without user context #678

Merged

tjementum merged 1 commit into main from pp-310-ensure-consistent-logout-redirect

Jan 25, 2025

Member

tjementum commented Jan 25, 2025

Summary & Motivation

Fix an issue where logging out from a page without user context did not immediately redirect the user. While the authentication cookies were removed, the logout was only detected after an authenticated API request failed with a 401 Unauthorized response.

Now, the logout logic immediately redirects the browser to the loginPath, ensuring an instant logout experience rather than waiting for a failed request. This makes the logout process more seamless and responsive.

Checklist

I have added tests, or done manual regression tests
I have updated the documentation, if necessary


          Make logout redirect consistent across all pages

65fe4f7

tjementum added the Enhancement label

tjementum self-assigned this

linear bot commented Jan 25, 2025

PP-310 Logout does not always redirect to logged out pages

sonarqubecloud bot commented Jan 25, 2025

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

tjementum merged commit 21810c8 into main

9 checks passed

tjementum deleted the pp-310-ensure-consistent-logout-redirect branch

January 25, 2025 23:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels