Fix pull-platformplatform-changes CLI command on Windows

[thiagolunardi]

Summary & Motivation

While running on Windows, the pp pull-platform platform-changes fails because it couldn't find the npm command, which is not an executable file.

This fix searches for the precise command location while running on Windows OS using the .exe and .cmd extensions.

Checklist

• I have added tests, and done manual regression tests
• I have updated the documentation, if necessary

[CLAassistant]

All committers have signed the CLA.

[tjementum]

Hi Tiago

Thanks for the pull request, and sorry for the late reply. I get an exception on my Mac when running this, and I had to debug to find out what was wrong. It turns out this is because the PATH environment variable on Linux and macOS is split using : and not ; like on Windows.

I made a comment and a suggested fix, but I will have to test that this did not break anything else. I don't have tests for the Developer CLI.

Also, I always rebase branches before merging to main, and I never merge main into a feature branch. Please rebase your changes and squash everything, including my suggested change, into a single commit, and then force push the branch to your repository.

[thiagolunardi]

Hi @tjementum

I can try adding a test project to it and putting together a workflow to test this functionality initially. I can run it on Windows, Linux, and Mac. For example, I can run npm—v and expect to get its version across all platforms.

public static class ProcessHelperTests
{
    public class StartProcessTests 
    {
        [Theory]
        [InlineData("npm -v")
        public void RequestVersion_ShouldReturnValidSemver(string command)
        {
                // Act
                var output = ProcessHelper.StartProcess(
                    command,
                    redirectOutput: true,
                    throwOnError: true);

                // Assert
                Assert.True(Version.TryParse(output, out _));
        }
    }
}

For that, I will need to make a tiny move and change the directory structure to look like this:

.
.
├─ development-cli       # Contains the development CLI source code
│  ├─ cli                # A .NET CLI tool for automating common developer tasks
│  ├─ tests              # Tests for the CLI

Do you think it makes sense?

[tjementum]

I've made the requested changes and force pushed them.