Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict container image pushes to main branch and streamline deployment workflows #193

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

tjementum
Copy link
Member

Summary & Motivation

Implement guards in both application.yml and _publish-container.yml to ensure container images are pushed exclusively from the main branch.

Remove the redundant success check for the staging job in production deployment, streamlining the workflow.

Simplify the creation of a non-root user in the Dockerfile by omitting the creation of a nonroot group.

Checklist

  • I have added a Label to the pull-request
  • I have added tests, and done manual regression tests
  • I have updated the documentation, if necessary

@tjementum tjementum added the Enhancement New feature or request label Oct 31, 2023
@tjementum tjementum self-assigned this Oct 31, 2023
Copy link

sonarcloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@tjementum tjementum merged commit c7f502f into main Oct 31, 2023
8 checks passed
@tjementum tjementum deleted the disable-publshing-of-container-on-pull-requests branch October 31, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow build pipelines to control which Docker version is active in which clusters
1 participant