Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve React component warnings and streamline application entry point #192

Merged
merged 5 commits into from
Nov 2, 2023
Merged

Resolve React component warnings and streamline application entry point #192

merged 5 commits into from
Nov 2, 2023

Conversation

tjementum
Copy link
Member

@tjementum tjementum commented Oct 31, 2023 •
edited
Loading

Summary & Motivation

Update package.json and bun.lockb to include the latest package versions, resolving the @types/react conflict that caused warnings for React Components like Button cannot be used as a JSX component.

Eliminate the react.svg favicon and its corresponding reference in index.html, and change the title of the app to PlatformPlatform.

Utilize the non-null assertion operator for the root element and omit the file extension in the App.tsx import for cleaner code. Rename index.css to main.css to align with RSPack conventions. Move the index.html to the public folder.

Checklist

  • I have added a Label to the pull-request
  • I have added tests, and done manual regression tests
  • I have updated the documentation, if necessary

@tjementum tjementum added Bug Something isn't working Enhancement New feature or request labels Oct 31, 2023
@tjementum tjementum requested a review from raix October 31, 2023 20:14
@tjementum tjementum linked an issue Oct 31, 2023 that may be closed by this pull request
Set up a core frontend foundation with Bun, React, React Aria Components, etc. #189
Closed
@tjementum tjementum self-assigned this Oct 31, 2023
@tjementum tjementum force-pushed the resolve-react-component-warnings branch from 8872c62 to 0a9398b Compare October 31, 2023 20:44
@tjementum tjementum removed the Bug Something isn't working label Oct 31, 2023
@tjementum tjementum force-pushed the resolve-react-component-warnings branch from 0a9398b to de8909d Compare November 1, 2023 14:57
@tjementum @raix
Ensure Tailwind styling is applied to index.html
f05e78d 
Co-authored-by: Morten N.O. Nørgaard Henriksen <[email protected]>
Signed-off-by: Thomas Jespersen <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@tjementum tjementum merged commit 5a73307 into main Nov 2, 2023
8 checks passed
@tjementum tjementum deleted the resolve-react-component-warnings branch November 2, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raix raix raix left review comments

Assignees

@tjementum tjementum

Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up a core frontend foundation with Bun, React, React Aria Components, etc.
2 participants
@tjementum @raix