Fix bug in configure-continuous-deployments CLI command when az CLI t…

…hrows an exception
platformplatform · Jan 26, 2025 · 94a34a1 · 94a34a1
1 parent 3b6e9ff
commit 94a34a1
Showing 1 changed file with 15 additions and 13 deletions.
diff --git a/developer-cli/Commands/ConfigureContinuousDeploymentsCommand.cs b/developer-cli/Commands/ConfigureContinuousDeploymentsCommand.cs
@@ -619,22 +619,24 @@ void CreateFederatedCredential(string appRegistrationId, string displayName, str
         {
             var parameters = JsonSerializer.Serialize(new
                 {
-                    name = displayName,
-                    issuer = "https://token.actions.githubusercontent.com",
-                    subject = $"""repo:{Config.GithubInfo!.Path}:{refRefsHeadsMain}""",
-                    audiences = new[] { "api://AzureADTokenExchange" }
-                }
+                name = displayName,
+                issuer = "https://token.actions.githubusercontent.com",
+                subject = $"""repo:{Config.GithubInfo!.Path}:{refRefsHeadsMain}""",
+                audiences = new[] { "api://AzureADTokenExchange" }
+            }
             );
 
             ProcessHelper.StartProcess(new ProcessStartInfo
                 {
-                    FileName = Configuration.IsWindows ? "cmd.exe" : "az",
-                    Arguments =
-                        $"{(Configuration.IsWindows ? "/C az" : string.Empty)} ad app federated-credential create --id {appRegistrationId} --parameters  @-",
-                    RedirectStandardInput = true,
-                    RedirectStandardOutput = !Configuration.VerboseLogging,
-                    RedirectStandardError = !Configuration.VerboseLogging
-                }, parameters
+                FileName = Configuration.IsWindows ? "cmd.exe" : "az",
+                Arguments =
+                    $"{(Configuration.IsWindows ? "/C az" : string.Empty)} ad app federated-credential create --id {appRegistrationId} --parameters  @-",
+                RedirectStandardInput = true,
+                RedirectStandardOutput = !Configuration.VerboseLogging,
+                RedirectStandardError = !Configuration.VerboseLogging
+            },
+                parameters,
+                exitOnError: false
             );
         }
     }
@@ -906,7 +908,7 @@ private string RunAzureCliCommand(string arguments, bool redirectOutput = true)
     {
         var azureCliCommand = Configuration.IsWindows ? "cmd.exe /C az" : "az";
 
-        return ProcessHelper.StartProcess($"{azureCliCommand} {arguments}", redirectOutput: redirectOutput);
+        return ProcessHelper.StartProcess($"{azureCliCommand} {arguments}", redirectOutput: redirectOutput, exitOnError: false);
     }
 
     private static Dictionary<string, string> GetAzureLocations()