Implement ACL APIs #174
Open
Implement ACL APIs #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change implements `createAcls`, `describeAcls`, and `deleteAcls` on the admin client. on-behalf-of: @SAP [email protected]
|
This seems to be a follow up of #150 due to #150 (comment) and #150 (comment). |
ShogunPanda
requested changes
Dec 1, 2025
| const aclSchema = { | ||
| type: 'object', | ||
| properties: { | ||
| resourceType: { type: 'number', enum: Object.values(ResourceTypes) }, |
Contributor
There was a problem hiding this comment.
Please use allowedResourceTypes as done elsewhere.
Same for all similar occurrences in this file.
| TRANSACTIONAL_ID: 5, | ||
| DELEGATION_TOKEN: 6 | ||
| DELEGATION_TOKEN: 6, | ||
| USER: 7 |
Contributor
There was a problem hiding this comment.
Revert all changes in his file, except the addition of new values like this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements
createAcls,describeAcls, anddeleteAclson the admin client.on-behalf-of: @SAP [email protected]