-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the jupyterhub/repo2docker
image
#217
base: master
Are you sure you want to change the base?
Conversation
7032bfe
to
bcef759
Compare
bcef759
to
0a76972
Compare
Environments seems to be building fine locally: Although servers time out on startup. Wondering if it could be related to the custom entrypoint used in Plasma, and the fact that it has since changed in
|
c.PlasmaSpawner.default_url = "/lab" | ||
# TODO: change back to jupyterhub-singleuser | ||
c.PlasmaSpawner.cmd = ["/srv/conda/envs/notebook/bin/jupyterhub-singleuser"] | ||
# set the default cpu and memory limits | ||
c.PlasmaSpawner.args = ["--ResourceUseDisplay.track_cpu_percent=True"] | ||
# explicitely opt-in to enable the custom entrypoint logic | ||
c.PlasmaSpawner.run_as_root = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now opt-in in dockerspawner>=12.0
: https://jupyterhub-dockerspawner.readthedocs.io/en/latest/changelog.html#id3
Not sure why we didn't have to set it explicitly before, as it was updated in #193.
@@ -43,4 +43,4 @@ export JUPYTER_PATH=${IMAGE_DIR}/.local/share/jupyter | |||
cd ${IMAGE_DIR} | |||
|
|||
# execute the notebook process as the given user | |||
exec su - $NB_USER -m -c '"$0" "$@"' -- "$@" | |||
exec su $NB_USER -m -c '"$0" "$@"' -- "$@" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK this seems to be doing the trick for being able able to launch the server.
If I understand correctly, specifying -
would be equivalent to starting the process with --login
, which conflicts with -m
/ --preserve-environment
.
As hinted by the the error logs:
su: ignoring --preserve-environment, it's mutually exclusive with --login
--root-prefix: 1 required TEXT missing
Run with --help for more information.
/srv/conda/envs/notebook/bin/jupyterhub-singleuser: 7: /etc/profile.d/activate-conda.sh: [[: not found
/srv/conda/envs/notebook/bin/jupyterhub-singleuser: 20: /etc/profile.d/activate-conda.sh: mamba: not found
JUPYTERHUB_API_TOKEN env is required to run jupyterhub-singleuser. Did you launch it manually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to do a bit more testing on a test VM, but this change might break compatibility with existing environments built with an older version of repo2docker
.
This issue is quite likely caused by jupyterhub/repo2docker#1287 and the latest version of |
Update the
jupyterhub/repo2docker
Docker image to point to a pinned version by default.The tag is made configurable in case so it's easier to override if needed, without having to update this repo.
Having a default pinned version makes it easier to reason about which version is being installed when the playbook is run multiple times.
Fixes #211
2023.06.0-41.g57d229e
repo2docker