fixed missing coverage for one-line lambdas in 3.11 #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! Any chance you'd be willing to add a test that replicates the issue? |
|
I added a simple test but apparently the current coverage report does report unexecuted lambdas as actually executed (probably due to covering the entire statement which defines the lambda). Delving into this requires a bit more time than I have now - but probably someone might want to examine this further. See the updated PR with the new test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #59 :
One-line lambdas are missing coverage probes (3.11).
If a lambda is not executed, we don't get any indication.
This is due to interplay between dis.findlinestarts() which removes duplicated, and slipcover.findlinestarts() which ignores noop-like opcode of RESUME and RETURN_GENERATOR.