Add --unsafe mode, add barebone safe mode to LLDB/GDB. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had bigger ideas for this, but let's keep it simple for time constraints. I may change it in the future. For now, a very restrictive safe mode: only a few no-side-effects functions allowed, plus print only allowing `[a-zA-Z0-9_ *]`. Added the `--unsafe` flag for all 3 debuggers to disable any security.
Put call to _getval inside try block for consistency: we catch and report the same errors regardless of whether we're sanitizing calls.
Revert `line[0]` back to `line[:1]`. The former crashes on an empty line; the latter is the empty string. Could refactor but don't want to make unnecessary changes...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had bigger ideas for this, but let's keep it simple for time constraints. I may change it in the future.
For now, a very restrictive safe mode: only a few no-side-effects functions allowed, plus print only allowing
[a-zA-Z0-9_ *].Added the
--unsafeflag for all 3 debuggers to disable any security.