chore: address deprecation warnings and attempt to address flaky Dependabot behavior #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I find having the output of the data we are working with for an action to be helpful in further development and troubleshooting of action issues.
Address a deprecation by GitHub: Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: planningcenter/planningcenter/pull-assign-action@v1 References: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
I noticed this action sometimes doesn't work. And in testing I see the
name for Dependabot is not always what we expect. But I see this is_bot
attribute so let's use it. Maybe that's why it sometimes fails.
{
"author": {
"is_bot": true,
"login": "app/dependabot"
}
}
This is mostly for my readability. I found this to be a nice flow when recently working on our planningcenter/plus-one-action GitHub action.
"user": {
...
"login": "dependabot[bot]",
"type": "Bot",
...
}
The PR output was massive and not so helpful. Let's just output the attributes we use in our logic.
robertleib
approved these changes
Jun 4, 2024
shanebonham
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started by looking into why Dependabot PRs sometimes fail with this action.
Then, that slowly morphed into some light refactoring. By walking through each commit separately, you can see the important changes of the
nodedeprecation and how we now check if a Bot made the PR being run against in two different ways.