Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: SAML support (backend) #311

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

SimonTagne
Copy link
Contributor

This is the back-end part for SAML authentication support.

Here are a few points where I would appreciate some advice:

  • The configuration in json is not really readable, especially when including PEM certs/keys
  • The constants for the authentication cookies are defined in the client source tree, and I don't know any good solution to access it in the ACS endpoint (it's hardcoded for now)

I'll start working on the front-end now and keep you updated

@meltyshev
Copy link
Member

The configuration in json is not really readable, especially when including PEM certs/keys

For the first version, I think it's fine. At some point we'll need to switch to a different format of settings 🤔

The constants for the authentication cookies are defined in the client source tree, and I don't know any good solution to access it in the ACS endpoint (it's hardcoded for now)

I’m also having this problem that there is no shared place with constants. I would just add a todo note, so as not to forget to take them out later when there is a shared place.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants