Skip to content

Commit

Permalink
Completely remove gh-ost and pt-osc
Browse files Browse the repository at this point in the history
Signed-off-by: Shlomi Noach <[email protected]>
  • Loading branch information
shlomi-noach committed Jan 23, 2025
1 parent 8d67991 commit 539ac24
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 852 deletions.
21 changes: 8 additions & 13 deletions go/vt/schemamanager/tablet_executor_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -206,12 +206,7 @@ func TestIsOnlineSchemaDDL(t *testing.T) {
query: "CREATE TABLE t(id int)",
isOnlineDDL: false,
},
{
query: "CREATE TABLE t(id int)",
ddlStrategy: "gh-ost",
isOnlineDDL: true,
strategy: schema.DDLStrategyGhost,
},

{
query: "ALTER TABLE t ADD COLUMN i INT",
ddlStrategy: "online",
Expand All @@ -231,16 +226,16 @@ func TestIsOnlineSchemaDDL(t *testing.T) {
},
{
query: "ALTER TABLE t ADD COLUMN i INT",
ddlStrategy: "gh-ost",
ddlStrategy: "vitess",
isOnlineDDL: true,
strategy: schema.DDLStrategyGhost,
strategy: schema.DDLStrategyVitess,
},
{
query: "ALTER TABLE t ADD COLUMN i INT",
ddlStrategy: "gh-ost --max-load=Threads_running=100",
ddlStrategy: "vitess --declarative",
isOnlineDDL: true,
strategy: schema.DDLStrategyGhost,
options: "--max-load=Threads_running=100",
strategy: schema.DDLStrategyVitess,
options: "--declarative",
},
{
query: "TRUNCATE TABLE t",
Expand All @@ -249,12 +244,12 @@ func TestIsOnlineSchemaDDL(t *testing.T) {
},
{
query: "TRUNCATE TABLE t",
ddlStrategy: "gh-ost",
ddlStrategy: "vitess",
isOnlineDDL: false,
},
{
query: "RENAME TABLE t to t2",
ddlStrategy: "gh-ost",
ddlStrategy: "vitess",
isOnlineDDL: false,
},
}
Expand Down
Loading

0 comments on commit 539ac24

Please sign in to comment.