fix: support empty subtitle

pkp · May 3, 2020 · 5ee8bde · 5ee8bde
1 parent e91772f
commit 5ee8bde
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/OrcidProfilePlugin.inc.php b/OrcidProfilePlugin.inc.php
@@ -982,7 +982,7 @@ public function buildOrcidWork($publication, $context, $authors, $request, $issu
  $bibtexCitation = trim(strip_tags($citationPlugin->getCitation($request, $submission, 'bibtex', $issue, $publication)));
 
  $publicationLocale = $publication->getData('locale');
- $titles = $publication->getData('title', $publicationLocale);
+
  $publicationUrl = $request->getDispatcher()->url($request, ROUTE_PAGE, null, 'article', 'view', $publication->getId());
 
  $orcidWork = [
@@ -991,7 +991,7 @@ public function buildOrcidWork($publication, $context, $authors, $request, $issu
  'value' => $publication->getLocalizedData('title', $publicationLocale)
  ],
  'subtitle' => [
- 'value' => $publication->getLocalizedData('subtitle', $publicationLocale)
+ 'value' => $publication->getLocalizedData('subtitle', $publicationLocale) ?? ''
  ]
  ],
  'journal-title' => [
@@ -1155,7 +1155,7 @@ private function buildOrcidContributors($authors, $contextId) {
  $orcid = basename(parse_url($author->getOrcid(), PHP_URL_PATH));
 
  if ($author->getData('orcidSandbox')) {
- $uri = 'https://sandbox.orcid.org/' . $orcid;
+ $uri = ORCID_URL_SANDBOX . $orcid;
  $host = 'sandbox.orcid.org';
  } else {
  $uri = $author->getOrcid();

diff --git a/pages/OrcidHandler.inc.php b/pages/OrcidHandler.inc.php
@@ -300,7 +300,7 @@ function orcidVerify($args, $request) {
  $plugin->getSetting($contextId, 'orcidProfileAPIPath') == ORCID_API_URL_PUBLIC_SANDBOX) {
  // Set a flag to mark that the stored orcid id and access token came form the sandbox api
  $authorToVerify->setData('orcidSandbox', true);
- $templateMgr->assign('orcid', 'https://sandbox.orcid.org/' . $response['orcid']);
+ $templateMgr->assign('orcid', ORCID_URL_SANDBOX . $response['orcid']);
  } else {
  $templateMgr->assign('orcid', $orcidUri);
  }