-
-
Notifications
You must be signed in to change notification settings - Fork 7
Add support for multiple Robinhood accounts #33
base: main
Are you sure you want to change the base?
Conversation
…e accounts. Data should end up stored as an array of objects `[{ robinHoodValue: '', mintValue: '' }]` Currently does NOT sanitize data Currently does NOT validate input
Just a heads-up, I was thinking about scraping the Robinhood account username and using it as a name on the properties, as a way of allowing multiple accounts to be set up. |
Some basic sanitization. Error color. Re adding `mint-force-sync`, may need to be removed on merge
…eaning up and sanitization.
…-accounts # Conflicts: # public/html/settings.html
Okay. Definitely will need a bit of cleanup, but should be functional at this point. |
…be overridden. (Turn off things like formatOnSave)
…-accounts # Conflicts: # .gitignore # .vscode/settings.json # public/html/settings.html
I'm going to plan to take at look a this over the weekend! |
Yeah, hopefully I'll get to look at it some more and clean it up before then. A bit more swamped than usual due to the shorter work week. |
…-accounts # Conflicts: # public/html/settings.html # src/background/main.ts # src/content/mint/properties/check.ts # src/content/mint/properties/update.ts
public/html/settings.html
Outdated
<div class="mutiple-accounts-input-wrapper"> | ||
<label> | ||
RobinHood Account Name | ||
<input required type="text" class="setting-multipleAccounts-robinHoodInput" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than having the user manually enter their account names, we can just scrape the account name every time we sync Robinhood. If the multiple account setting is not enabled, the value is ignored.
If it is enabled, we do a setup check (similar to the initial setup), where we check if this device has synced with the Robinhood account logged in. (These could be stored in an array in chrome.storage.sync). If the current device has not set up that account before, we can then trigger the property setup/check.
This would give users a more seamless experience, and reduce logic on the settings page since it would just be a checkbox.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, latest push should accomplish this...
Need to probably test some of the flows and make sure the notifications seem correct in each one.
... Probably also need to add a delete script under the debug at some point, more just for convienence, since adding and deleting all these accounts is crazy tedious.
Changing the returnValue.accountName = accountNameElement.innerText;
to a static value works well enough for testing to add new accounts.
…nt is new and add automatically.
…-accounts # Conflicts: # package-lock.json # package.json # public/manifest.json # src/background/main.ts # src/content/mint/properties/update.ts # src/content/robinhood/main.ts
Adds support for multiple Robinhood accounts. (closes #16)
[{ robinHoodValue: '' }]
Other tidbits:
urls
&interfaces
toconstants
foldervscode/settings.json
vscode/settings.json.default
so devs can opt in to the projects default settings but still overwrite if needed.vscode/extensions.json
recomending eslint as an extension.lint:fix
command added for quick linting.