Simplify UI for devices that only have a power state #12
Conversation
Only add the TelevisionSpeaker service if we have a device with mute state implemented (which is required for TelevisionSpeaker), which simplifies the UI displayed in HomeKit for things that only have a power state. Additionally, the empty array checks in the Homebridge callbacks weren't working as it turns out `[]` is truthy - which was causing Homebridge to complain that the callback was never called. This check shouldn't actually be needed any more with the first change, but I fixed that before realising the service could be removed completely.
|
This fixes #8 |
Heya - I can't see them I'm afraid! If they're in a review, double-check the whole review was submitted at the top of the page 😄 |
| ); | ||
|
|
||
| // Mute is a required characteristic for TelevisionSpeaker, if we don't have any mutable devices don't register the service. | ||
| if (this.devicesToQueryForMute?.length) { |
There was a problem hiding this comment.
We should instead check if the volume and/or mute command(s) are configured. It is possible for the volume/mute commands to be configured via only LIRC, at which point there is no devicesToQueryForMute since LIRC can't be queried. The state falls back to this.states.mute in that case.
|
|
||
| // register inputs | ||
| this.device.inputs.forEach( |
There was a problem hiding this comment.
We should update the type on inputs to be optional
| @@ -136,7 +136,7 @@ interface UniversalControlDevice { | |||
| */ | |||
| export class Television { | |||
| private tvService: Service; | |||
| private tvSpeakerService: Service; | |||
| private tvSpeakerService: Service | undefined; | |||
There was a problem hiding this comment.
Instead of | undefined, use tvSpeakerService?: Service to be consistent with other possibly undefined type definitions.
Only add the TelevisionSpeaker service if we have a device with mute state implemented (which is required for TelevisionSpeaker), which simplifies the UI displayed in HomeKit for things that only have a power state.
Additionally, the empty array checks in the Homebridge callbacks weren't working as it turns out
[]is truthy - which was causing Homebridge to complain that the callback was never called. This check shouldn't actually be needed any more with the first change, but I fixed that before realising the service could be removed completely.I ran into this troubleshooting a warning from Homebridge:
with a very basic config for my projector:
{ "groups": [ { "name": "Projector", "devices": { "serial": [ { "name": "Projector", "path": "/dev/ttyUSB0", "requestTimeout": 150, "delimiter": "\u0003", "getStatus": { "power": { "command": "\u0002QPW\u0003", "onResponse": "\u0002001", "offResponse": "\u0002000" } } } ] }, "power": { "on": { "commands": [ { "serial": [ { "commands": ["\u0002PON\u0003"], "device": "Projector" } ] } ] }, "off": { "commands": [ { "serial": [ { "commands": ["\u0002POF\u0003"], "device": "Projector" } ] } ] } }, "inputs": [], "manufacturer": "Panasonic", "model": "AT6000E" } ], "platform": "TelevisionUniversalControl" }