Add CI #12
Add CI #12
Conversation
Signed-off-by: Dominykas Blyžė <[email protected]>
|
Ideally, the tests would pass without any setup (i.e. without the need for a token), so I guess we should split the tests that need network and the ones that don't at some point later. |
| - "14" | ||
|
|
||
| cache: | ||
| npm: false |
There was a problem hiding this comment.
this is the default, fwiw, so this line isn't needed
There was a problem hiding this comment.
So the docs are wrong? https://docs.travis-ci.com/user/caching/#npm-cache
There was a problem hiding this comment.
apparently i'm wrong as of a year ago :-) "Please note that as of July 2019, npm is cached by default on Travis CI" my mistake.
.travis.yml
Outdated
| - "10" | ||
| - "12" | ||
| - "14" |
There was a problem hiding this comment.
nit: sort the newest at the top
| - "10" | |
| - "12" | |
| - "14" | |
| - "14" | |
| - "12" | |
| - "10" |
There was a problem hiding this comment.
Updated in 5b5e684, but for the record I find this change entirely pointless.
Nits like this are distracting, discouraging and demotivating.
There was a problem hiding this comment.
I'm sorry I caused you to feel this way; I'd love to understand more about why it's discouraging or demotivating. To me, this is just part of any code review. It being a "nit" just means it's not a blocker, and i'd be happy to explain why it's not pointless if you're interested.
There was a problem hiding this comment.
The motivation for the ordering probably matters more on nodejs/ci-config-travis#6 than here.
There was a problem hiding this comment.
In an imported config, the order is backwards; so i believe it's correct there :-)
test/github.js
Outdated
| tap.equal(JSON.stringify(await github.getPackageJson(CONFIG.DEP_ORG, CONFIG.DEP_REPO)), JSON.stringify(CONFIG.PKGJSON)) | ||
| // tap.throws( await pkgTest.getPackageJson('not-an-org', 'not-a-repo')) | ||
| }) | ||
| if (process.env.GITHUB_TOKEN) { |
There was a problem hiding this comment.
does tap not have a "skip" mechanism?
There was a problem hiding this comment.
My google led me to issues for jest, not tap 🤦 0d5460d
|
🎉 This PR is included in version 0.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Some CI is better than no CI
Closes #5