add Node.js 18, 20 and 22 to engines
#51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm. It looks like tests are broken everywhere (even for the older Node.js versions that this PR doesn't change). 😞 |
|
We should probably just change this to |
richardlau
force-pushed
the
update-engines
branch
from
1c7da68
to
c806655
Compare
I don't think so -- I was going with "don't disturb anything already there". I've updated the field to |
npm 10.8.2 doesn't install the `latest` tagged version of @pkgjs/support with Node.js 22 as Node.js 22 is outside of the declared specification for `engines`->`node`. Regardless of whether the change in behaviour of npm is correct for a semver-patch release of npm, update the `engines` field to include the supported Node.js release lines at this point in time.
richardlau
force-pushed
the
update-engines
branch
from
c806655
to
e144e6b
Compare
wesleytodd
approved these changes
Aug 7, 2024
lholmquist
approved these changes
Aug 7, 2024
ljharb
approved these changes
Aug 7, 2024
ruyadorno
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm 10.8.2 doesn't install the
latesttagged version of @pkgjs/support with Node.js 22 as Node.js 22 is outside of the declared specification forengines->node.Regardless of whether the change in behaviour of npm is correct for a semver-patch release of npm, update the
enginesfield to include the supported Node.js release lines at this point in time.Refs: npm/cli#7704 (comment)