Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package metadata should match the license file #154

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yufukui-m
Copy link

which license is correct, in package.json or LICENSE?

@shadowspawn
Copy link
Collaborator

Related: #153

@ljharb
Copy link
Member

ljharb commented Aug 7, 2024

The package declaration imo is correct, not the license file.

@shadowspawn
Copy link
Collaborator

I suspect it is a mess to land a fix. We might need agreement from all previous contributors, and a major version release to change the licence.

I am a contributor, and I don't mind which licence we use. I prefer MIT as shorter and I think more common for npm packages.

@ljharb
Copy link
Member

ljharb commented Aug 18, 2024

We don’t need a major version if we’re not changing the license field, because that’s the only thing tools look at.

We may indeed want to confirm that contributors werent confused by the incorrect license file, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants