feat: migrate to @npmcli/package-json #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleytodd
commented
Dec 7, 2023
| } else if (pkg && typeof pkg.repository !== 'undefined' && pkg.repository.url) { | ||
| repo = pkg.repository.url; | ||
| } | ||
| return repo; | ||
| }; |
There was a problem hiding this comment.
I am wondering now if we can delete all this since @npmcli/package-json does more normalization?
ljharb
reviewed
Dec 7, 2023
wesleytodd
commented
Dec 7, 2023
wesleytodd
commented
Dec 7, 2023
| packageInstance = await PackageJson.load(opts.cwd, { | ||
| create: true | ||
| }); | ||
| pkg = packageInstance.content; |
There was a problem hiding this comment.
Not sure if there was a better way, but to reduce the surface of this change I do this so we can just modify the object and leave all those other lines alone.
wesleytodd
force-pushed
the
package-json-npmcli
branch
from
7d48a91
to
31cf513
Compare
wesleytodd
force-pushed
the
package-json-npmcli
branch
from
31cf513
to
ce51568
Compare
|
@ljharb I am going to take the fact this is "comments" and they have been resolved it is not a blocking review. I will merge this up and publish sometime today if I don't hear a back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes all the tests, but frankly I am surprised this did not break more tests. I am worried this is a breaking change we just don't have tests for lol. Anyway, let me know what y'all think.