Skip to content

Commit

Permalink
enable InheritsCheck by default
Browse files Browse the repository at this point in the history
  • Loading branch information
mgorny committed Sep 2, 2021
1 parent 7848214 commit 7bb29cc
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
4 changes: 3 additions & 1 deletion NEWS.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,15 @@ Release Notes
=============

---------------------------
pkgcheck 0.10.6 (2021-??-??)
pkgcheck 0.10.6 (2021-09-02)
---------------------------

- add a check for calling EXPORT_FUNCTIONS before further inherits.

- InheritsCheck: process @PROVIDES recursively.

- InheritsCheck: enable by default.

----------------------------
pkgcheck 0.10.5 (2021-08-16)
----------------------------
Expand Down
4 changes: 2 additions & 2 deletions src/pkgcheck/checks/codingstyle.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

from .. import addons, bash
from .. import results, sources
from . import Check, OptionalCheck
from . import Check

PREFIX_VARIABLES = ('EROOT', 'ED', 'EPREFIX')
PATH_VARIABLES = ('BROOT', 'ROOT', 'D') + PREFIX_VARIABLES
Expand Down Expand Up @@ -577,7 +577,7 @@ def desc(self):
return f'{self.eclass}: internal usage: {repr(self.usage)}, line {self.lineno}'


class InheritsCheck(OptionalCheck):
class InheritsCheck(Check):

This comment has been minimized.

Copy link
@radhermit

radhermit Sep 2, 2021

Contributor

Just a warning, this change along with pkgcore/pkgcore@be5e05b will cause significant slowdowns for what I imagine are still the majority of pkgcheck users since most don't use pmaint regen to generate their repo metadata. In addition, there will be metadata cache contention between pkgcore and portage since the content isn't the same anymore when enabling this.

"""Scan for ebuilds with missing or unused eclass inherits.
Note that this requires using ``pmaint regen`` to generate repo metadata in
Expand Down

0 comments on commit 7bb29cc

Please sign in to comment.