Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend timeouts on http operations #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

julian-hj
Copy link
Member

This change addresses pivotal-cf/pivnet-resource#129

We have some operations against pivnet that consistently take a couple of minutes, so failing after 1 minute of waiting causes blocking issues in our pipelines.

CC @angelachin


Thank you for contributing to the go-pivnet API library!

  • Have you made this pull request to the develop branch?
    The develop branch does not appear to exist.
  • Have you run the tests locally?
    We ran the units.

@pivotal-issuemaster
Copy link

@julian-hj Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@julian-hj Thank you for signing the Contributor License Agreement!

@cjnosal
Copy link
Contributor

cjnosal commented Jul 21, 2020

Regarding our comment on pivotal-cf/pivnet-resource#129 (comment) would you be interested in iterating on this PR?

@julian-hj
Copy link
Member Author

Regarding our comment on pivotal-cf/pivnet-resource#129 (comment) would you be interested in iterating on this PR?

...Maybe? I am not sure whether we will have bandwidth or not, but we would defintely like to help. In the near term, is there some reason that a 10 minute timeout is problematic? We haven't seen any use cases on our (RelEng) end that get worse with a longer timeout, but maybe y'all have some cases that are different from ours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants