This repository has been archived by the owner on Nov 7, 2018. It is now read-only.
Add source of shard awareness attr #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pires
suggested changes
Apr 7, 2018
| @@ -64,6 +64,7 @@ ENV NUMBER_OF_MASTERS 1 | |||
| ENV MAX_LOCAL_STORAGE_NODES 1 | |||
| ENV SHARD_ALLOCATION_AWARENESS "" | |||
| ENV SHARD_ALLOCATION_AWARENESS_ATTR "" | |||
| ENV SHARD_ALLOCATION_AWARENESS_ATTR_SOURCE FILE | |||
There was a problem hiding this comment.
Why default to file and break existing behavior?
pires
force-pushed
the
master
branch
3 times, most recently
from
738723d to
e14ad80
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added something to let you pick between using an env var vs. a file for the contents of the awareness attribute. Not sure if this is useful, but it helps in my case.