Use plugin registry instead of pluginClients and stageBasedPluingsMap in the controller, scheduler, and planner #5472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5472 +/- ##
==========================================
+ Coverage 26.17% 26.19% +0.01%
==========================================
Files 458 458
Lines 49169 49172 +3
==========================================
+ Hits 12871 12881 +10
+ Misses 35275 35267 -8
- Partials 1023 1024 +1 ☔ View full report in Codecov by Sentry. |
… in the controller, scheduler, and planner Signed-off-by: Yoshiki Fujikane <[email protected]>
ffjlabo
force-pushed
the
use-plugin-registry
branch
from
47fc867 to
40c6c1e
Compare
|
FYI, I checked the behavior of the four cases with the patch. diff.patch
It works as I expected. Only
Only
Both
None of
|
ffjlabo
requested review from
nghialv,
khanhtc1202,
kentakozuka,
t-kikuc and
Warashi
as code owners
Warashi
reviewed
Jan 9, 2025
Signed-off-by: Yoshiki Fujikane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
Why we need it:
Until now, we use
pluginClientsandstageBasedPluingsMapin thecontroller,scheduler,plannerto determine the plugin for the app.However, we implemented the plugin registry in #5467 to determine the plugin used to deploy an app from the app config.
So, we will use it instead of
pluginClientsandstageBasedPluingsMapfrom now on.Which issue(s) this PR fixes:
Part of #4980
Follows #5467 #5470
Does this PR introduce a user-facing change?: