Implemented the backend of Metadata APIs as MetadataStoreRegistry

[t-kikuc]

What this PR does:

1. Created MetadataStoreRegistry
   • It contains metadataStores for deployments.
   • It's the backend of MetadataStore methods in the PluginAPI
   • It adds a new metadataStore for a deployment in controller by Register().
     • Unlike pipedv0 scheduler. It passes metadataStore as Input.
2. Simplified reading metadata in planner & scheduler (5e3eea7)
   • They don't need metadataStore

Overview of New MetadataStore:

Why we need it:

• This is the server-side implementation of MetadataStore methods of PluginServiceServer.
• MetadataStoreRegistry is needed because PluginServiceServer does not exist per Deployment.

Note:

I want to refactor some points in pkg/app/pipedv1/metadatastore/store.go after this PR.

• Convert some methods to be private (e.g. NewMetadataStore())
• Use only deploymentID instead of the whole deployment (here)

I won't make drastic changes in the store.

Which issue(s) this PR fixes:

Part of #4980
Follows #5469

Does this PR introduce a user-facing change?:

• How are users affected by this change:
• Is this breaking change:
• How to migrate (if breaking change):

[Warashi]

The overview is good, and deleting the metadata store from the controller/planner is nice.

I have one concern about deployment metadata.
We will face a weird bug when multiple plugins use the same key to store deployment metadata.
I think it's good to append the plugin-name prefix to the deployment metadata key, WDYT?

[Warashi]

Oops, we don't have a way to determine the plugin that requests piped to store deployment metadata. It's difficult to append the plugin-name prefix...

[Warashi]

It's okay to start with this implementation.
Let's re-think this when we implement a way to determine which plugin sends requests to the piped service.

[t-kikuc]

@Warashi
Thank you, in the next PR, I'll update to separate Deployment Metadata into (1)plugin-specific and (2)shared across piped and plugins.

A plugin will

• a. explicitly specify the name of another plugin to access its metadata
• b. use another method (GetDeploymentSharedMetadata()) for (2)

[t-kikuc]

in the next PR, I'll update to separate Deployment Metadata into (1)plugin-specific and (2)shared across piped and plugins.

After merging this PR, I'll create a PR with this branch:
https://github.com/pipe-cd/pipecd/tree/plugin/metadatastore-v5

[t-kikuc]

I solved the conflict: 3f448d0

[codecov]

Codecov Report

Attention: Patch coverage is 66.02564% with 53 lines in your changes missing coverage. Please review.

Project coverage is 26.31%. Comparing base (58fda21) to head (4c90308).
Report is 19 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/app/pipedv1/cmd/piped/grpcapi/plugin_api.go	0.00%	20 Missing ⚠️
pkg/app/pipedv1/metadatastore/registry.go	77.92%	12 Missing and 5 partials ⚠️
pkg/app/pipedv1/controller/controller.go	0.00%	11 Missing ⚠️
pkg/app/pipedv1/cmd/piped/piped.go	0.00%	3 Missing ⚠️
pkg/app/pipedv1/controller/planner.go	0.00%	1 Missing ⚠️
pkg/app/pipedv1/controller/scheduler.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5471      +/-   ##
==========================================
+ Coverage   26.24%   26.31%   +0.07%     
==========================================
  Files         458      462       +4     
  Lines       49364    49535     +171     
==========================================
+ Hits        12954    13036      +82     
- Misses      35383    35466      +83     
- Partials     1027     1033       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ffjlabo]

Almost all LGTM! I just left a comment for test.

[ffjlabo]

[nit] It would be nice to use t.Logf instead of fmt.Printf

[t-kikuc]

@ffjlabo
Thank you, I fixed it: 4c90308.

[ffjlabo]

LGTM!

[Warashi]

LGTM