Skip to content

Commit

Permalink
Cherry-pick #5100 #5104 (#5105)
Browse files Browse the repository at this point in the history
* Fix firestore index (#5100)

Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>

* Update RELEASE to v0.48.4 (#5104)

Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>

---------

Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
Co-authored-by: Yoshiki Fujikane <[email protected]>
  • Loading branch information
github-actions[bot] and ffjlabo authored Aug 2, 2024
1 parent 57805c1 commit eec680f
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 11 deletions.
2 changes: 1 addition & 1 deletion RELEASE
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
tag: v0.48.3
tag: v0.48.4

releaseNoteGenerator:
showCommitter: false
Expand Down
5 changes: 0 additions & 5 deletions pkg/app/ops/firestoreindexensurer/indexes.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,6 @@
"collectionGroup": "Application",
"queryScope": "COLLECTION",
"fields": [
{
"fieldPath": "Deleted",
"order": "ASCENDING",
"arrayConfig": ""
},
{
"fieldPath": "CreatedAt",
"order": "ASCENDING",
Expand Down
5 changes: 0 additions & 5 deletions pkg/app/ops/firestoreindexensurer/indexes_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,6 @@ func TestParseIndexes(t *testing.T) {
CollectionGroup: "Application",
QueryScope: "COLLECTION",
Fields: []field{
{
FieldPath: "Deleted",
Order: "ASCENDING",
ArrayConfig: "",
},
{
FieldPath: "CreatedAt",
Order: "ASCENDING",
Expand Down

0 comments on commit eec680f

Please sign in to comment.