Improve project composition #2
Conversation
|
Hello again! I'm actually very impressed with that layout, I've never seen a project structure like that. Don't have time for a proper review, but at a first glance I noticed you haven't run Thank you! |
|
This project using this structure https://github.com/Hopetree/izone |
|
and I’m build this website using same structure |
|
Also, I added Poetry to make package management easier. It is optional for users as we're also sharing requirements.txt. |
apps/api/serializers.py
Outdated
| from notifications.models import Notification | ||
|
|
||
|
|
||
| User = get_user_model() |
There was a problem hiding this comment.
User is not used in this file, please remove it.
apps/api/serializers.py
Outdated
| @@ -1,6 +1,12 @@ | |||
| from django.contrib.auth import get_user_model | |||
There was a problem hiding this comment.
User model is not used in this file, please remove it.
| "allauth", | ||
| "allauth.account", | ||
| "allauth.socialaccount", | ||
| "rest_auth.registration", | ||
|
|
||
| "entries.apps.EntriesConfig", | ||
| 'messeges.apps.MessegesConfig', |
There was a problem hiding this comment.
you cant use this because django already use it Messages App
There was a problem hiding this comment.
Well then you have to come up with a new name :D
Maybe private_messages?
There was a problem hiding this comment.
I prefer not to use the _ to create Django applications. We can change the model name to Message
There was a problem hiding this comment.
Model name is good, I'm not fine with a typo in apps name. If not private_messages then maybe inbox, private, conversations, etc.
There was a problem hiding this comment.
Looks good overall but still not sure about app names being plural i.e. users not user but I guess I could live with that.
I left some minor comments that should be addressed so when these are resolved and pre-commit is applied I will accept this PR.
Thank you!
I did it depending on the structure of the Django applications, for example |
Understood, as I said I can live with that :) |
|
Hey, I see you've hidden/removed your fork repository. Should I remove the PR? |
Hello again
I just modified the project's external structure and did not delete or modify any major components in the project