fix: fix function name reference

pionxzh · Aug 11, 2024 · 48feaba · 48feaba
1 parent 091c68c
commit 48feaba
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/packages/ast-utils/src/reference.ts b/packages/ast-utils/src/reference.ts
@@ -171,6 +171,7 @@ export function findReferences(
 ): Collection<Identifier> {
     const targetScope = 'bindings' in nodeOrScope ? nodeOrScope : j(nodeOrScope).get().scope as Scope
     const range = 'bindings' in nodeOrScope ? nodeOrScope.path : nodeOrScope
+    const rangeNode = 'node' in range ? range.node : range
 
     return j(range)
         .find(j.Identifier, { name: identifierName })
@@ -179,6 +180,11 @@ export function findReferences(
             // ignore properties (e.g. in MemberExpression
             if (path.name === 'property' && j.MemberExpression.check(path.parent.node) && !path.parent.node.computed) return false
 
+            // ignore function name that is at the top level
+            if (path.parent.node === rangeNode && j.FunctionDeclaration.check(path.parent.node) && path.parent.node.id === path.node) {
+                return false
+            }
+
             if (!path.scope) return false
 
             let scope: Scope | null = path.scope

diff --git a/packages/unminify/src/transformations/__tests__/smart-inline.spec.ts b/packages/unminify/src/transformations/__tests__/smart-inline.spec.ts
@@ -323,6 +323,25 @@ function foo() {
 `,
 )
 
+inlineTest('property destructuring - resolve naming conflicts #4',
+  `
+function J(U) {
+  const B = U.children;
+  const G = U.className;
+  const J = U.description;
+}
+`,
+  `
+function J(U) {
+  const {
+    children,
+    className,
+    description
+  } = U;
+}
+`,
+)
+
 inlineTest('array destructuring',
   `
 const t = e[0];