Skip to content

Dynamic load detectors and transformers#1652

Merged
wbh123456 merged 3 commits intopinterest:masterfrom
wbh123456:bohao/detector_fix
Feb 18, 2026
Merged

Dynamic load detectors and transformers#1652
wbh123456 merged 3 commits intopinterest:masterfrom
wbh123456:bohao/detector_fix

Conversation

@wbh123456
Copy link
Contributor

@wbh123456 wbh123456 commented Feb 5, 2026

Refactored both detector.ts and transformer.tsx to fix a race condition where custom column detectors and transformers (loaded via window.CUSTOM_COLUMN_DETECTORS and window.CUSTOM_COLUMN_TRANSFORMERS) were not being applied if the custom script loaded after the main bundle.

The application now fetches the latest custom configurations every time it processes a table or requests transformers, ensuring that asynchronously loaded plugins are correctly registered and used.

Test:
Tested in devapp.
image_signature is now successfully loading with the proper transformer.
Screenshot 2026-02-05 at 3 49 02 PM

Jira:
https://pinterest.atlassian.net/browse/AP-5568

@wbh123456 wbh123456 force-pushed the bohao/detector_fix branch 2 times, most recently from 7de60ff to 7b12c03 Compare February 5, 2026 21:12
@wbh123456 wbh123456 merged commit b0c1826 into pinterest:master Feb 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments