fix: repalcement txs check inside for loop

pinheadmz · Aug 12, 2022 · ddc9ac8 · ddc9ac8
1 parent 432a30d
commit ddc9ac8
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/lib/mempool/mempool.js b/lib/mempool/mempool.js
@@ -983,6 +983,14 @@ class Mempool extends EventEmitter {
         conflictingFees += conflict.descFee;
         totalEvictions += this.countDescendants(conflict) + 1;
 
+        // Replacement TXs must not evict/replace more than 100 descendants
+        if (totalEvictions > 100) {
+          throw new VerifyError(tx,
+          'nonstandard',
+          'too many potential replacements',
+          0);
+        }
+
         if (entry.getDeltaRate() <= conflict.getDeltaRate()) {
           throw new VerifyError(tx,
           'insufficientfee',
@@ -991,14 +999,6 @@ class Mempool extends EventEmitter {
         }
       }
 
-      // Replacement TXs must not evict/replace more than 100 descendants
-      if (totalEvictions > 100) {
-        throw new VerifyError(tx,
-        'nonstandard',
-        'too many potential replacements',
-        0);
-      }
-
       // Replacement TX must also pay for the total fees of all descendant
       // transactions that will be evicted if an ancestor is replaced.
       // Thus the replacement "pays for the bandwidth" of all the conflicts.