-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feat: enhanced zoom and full screen image preview experience of doc site #464
Open
curiousRay
wants to merge
29
commits into
pingcap:master
Choose a base branch
from
curiousRay:203-zoom-image
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@curiousRay is attempting to deploy a commit to the pingcap Team on Vercel. A member of the Team first needs to authorize it. |
qiancai
added
2024-tidb-docs-dash
contribution
Indicates that the issue or PR was contributed by an external member.
labels
Jan 12, 2024
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
qiancai
added
the
tidb-docs-dash-bonus
Indicates that the issue or PR with bonus points
label
Jan 25, 2024
New method of displaying the full screen image, rather than invoking the browser's API
@Yuiham I updated the code :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2024-tidb-docs-dash
contribution
Indicates that the issue or PR was contributed by an external member.
tidb-docs-dash-bonus
Indicates that the issue or PR with bonus points
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First-time contributors' checklist
What is changed, added or deleted? (Required)
ImageZoomable.tsx
.Fix #203
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?