Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiup-cluster: support clearing extra data dirs automatically when destroying cluster. #2477

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

LykxSassinator
Copy link

@LykxSassinator LykxSassinator commented Dec 3, 2024

What problem does this PR solve?

For example, if using the following configs:

global_configs:
  data-dir: /tikv/data

server_configs:
  tikv:
    raft-engine.dir: "/data1/raft"
    raft-engine.spill-dir: "/data1/spill"

The default data directory is set to use /tikv/data as the root path, while raft logs are stored in a distinct location at /data1/raft. However, this configuration results in the tiup-cluster destroy command failing to remove the raft logs as intended, leading to a leak of raft data that should be cleared.

This pr is introduced to make tiup-cluster clear extra data directories if specified.

What is changed and how it works?

Two parts:

  • Records the extra directories by getExtraDeployDirs and inserts them into Instance.Dirs when init.
  • Clear them when destroying TiKV instances.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 3, 2024
@CLAassistant
Copy link

CLAassistant commented Dec 3, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

ti-chi-bot bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested review from breezewish and nexustar December 3, 2024 02:18
Copy link
Contributor

ti-chi-bot bot commented Dec 3, 2024

Welcome @LykxSassinator! It looks like this is your first PR to pingcap/tiup 🎉

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 3, 2024
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator LykxSassinator changed the title TiKV: support clearing extra data dirs automatically when destroying cluster. tiup-cluster: support clearing extra data dirs automatically when destroying cluster. Dec 3, 2024
@LykxSassinator LykxSassinator marked this pull request as ready for review December 3, 2024 03:44
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants