-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip destroy monitor when ignore_exporter is true #2197
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Smityz <[email protected]>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2197 +/- ##
==========================================
- Coverage 56.14% 55.97% -0.17%
==========================================
Files 320 320
Lines 33866 33866
==========================================
- Hits 19014 18956 -58
- Misses 12583 12641 +58
Partials 2269 2269
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I suggest to move this if to "instCount[inst.GetManageHost()]--".So it will have the same behave like deploy.(If there are two instant on one machine, only one has "nomonitor" config, tiup cluster will deyloy and destroy monitor on this machine) |
updated |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: srstack The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
when
ignore_exporter: true
is setting, tiup should skip destroying node exporter