Skip to content

Commit

Permalink
Include MySQL 9.x in versions that don't need --comments (#2469)
Browse files Browse the repository at this point in the history
  • Loading branch information
dveeden authored Dec 10, 2024
1 parent f7d5cb8 commit c39bd6e
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion components/playground/playground.go
Original file line number Diff line number Diff line change
Expand Up @@ -1669,7 +1669,12 @@ func mysqlCommand() (cmd string) {
}
vMaj, vMin, _, err := parseMysqlVersion(string(mysqlVerOutput))
if err == nil {
if vMaj == 8 && vMin >= 1 { // 8.1.0 and newer
// MySQL Client 8.1.0 and newer
if vMaj == 8 && vMin >= 1 {
return "mysql"
}
// MySQL Client 9.x.x. Note that 10.x is likely to be MariaDB, so not using >= here.
if vMaj == 9 {
return "mysql"
}
}
Expand Down

0 comments on commit c39bd6e

Please sign in to comment.