planner: implements support for dumping multiple SQL statements in a single `PLAN REPLAYER DUMP EXPLAIN` command by qw4990 · Pull Request #66162 · pingcap/tidb

qw4990 · 2026-02-09T07:27:17Z

What problem does this PR solve?

Issue Number: close #66151

Problem Summary: Implements support for dumping multiple SQL statements in a single PLAN REPLAYER DUMP EXPLAIN command, addressing issue #66151.

What changed and how does it work?

Parser

Added StmtList []string field to PlanReplayerStmt AST
Added grammar rules for PLAN REPLAYER DUMP EXPLAIN ( 'sql1', 'sql2', ... )
Updated Restore method to handle multi-SQL format

Planner/Executor

Added StmtList field to PlanReplayer plan
Executor builder parses SQL strings from StmtList into AST nodes

Dump Output

Single SQL (backward compatible): sql/sql0.sql + explain.txt
Multiple SQLs: sql/sql0.sql, sql/sql1.sql, ... + explain/explain0.txt, explain/explain1.txt, ...
Fixed table extraction to properly handle unqualified table names

Example

PLAN REPLAYER DUMP EXPLAIN (
    'SELECT * FROM t1 WHERE id = 1',
    'SELECT * FROM t1 WHERE id > 1',
    'SELECT * FROM t2 WHERE status = "active"'
);

Output zip contains:

/sql/sql0.sql, /sql/sql1.sql, /sql/sql2.sql
/explain/explain0.txt, /explain/explain1.txt, /explain/explain2.txt
Schema/stats files for referenced tables (collected once)

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

pantheon-ai · 2026-02-09T07:27:26Z

This PR adds support for dumping multiple SQL statements in a single PLAN REPLAYER DUMP EXPLAIN by extending the parser/AST and wiring StmtList through the planner/executor to parse each SQL into AST nodes. It updates dump output to generate sql/sql0.sql, sql/sql1.sql, … and matching explain/explain0.txt, explain/explain1.txt, … while keeping single-SQL behavior backward compatible. It also fixes table extraction for unqualified table names.

_{Learn more about Pantheon AI}

tiprow · 2026-02-09T07:27:33Z

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

qw4990 · 2026-02-09T07:28:45Z

@pantheon-bot please review

pantheon-ai · 2026-02-09T07:28:55Z

✅ Review Complete

I've completed a comprehensive review of PR #66162 (planner: implements support for dumping multiple SQL statements in a single PLAN REPLAYER DUMP EXPLAIN command).

Review Summary

Status: 1 issue found (P2)
P0/P1 Issues: None ✓
P2 Issues: 1 (usability concern)

Key Findings

P2: Misleading error for multi-SQL parse failures

Location: pkg/executor/builder.go:1189
Impact: When SQL statements in the multi-SQL list fail to parse, users receive a generic "plan replayer: sql is empty" error instead of the actual parse error, making debugging difficult
Details: Parse errors are only logged as warnings, and the executor creates an empty replayer file before failing
Recommendation: Propagate parse errors properly with statement index information

👉 View detailed review comments

Overall Assessment

✅ No blocking issues found. The implementation correctly adds multi-SQL support to PLAN REPLAYER DUMP EXPLAIN with proper backward compatibility. The P2 issue is a usability improvement that can be addressed in a follow-up.

qw4990 · 2026-02-09T07:35:36Z

/test mysql-test

tiprow · 2026-02-09T07:36:03Z

@qw4990: PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test.

Details

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2026-02-09T07:51:42Z

Codecov Report

❌ Patch coverage is 90.90909% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.6517%. Comparing base (eb2cd22) to head (0b80fb7).
⚠️ Report is 20 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #66162        +/-   ##
================================================
+ Coverage   77.7712%   79.6517%   +1.8804%     
================================================
  Files          2001       1952        -49     
  Lines        546334     538542      -7792     
================================================
+ Hits         424891     428958      +4067     
+ Misses       119783     108102     -11681     
+ Partials       1660       1482       -178

Flag	Coverage Δ
integration	`47.9114% <42.8571%> (-0.2824%)`	⬇️
unit	`76.8605% <90.9090%> (+0.4552%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`56.7974% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`65.7255% <ø> (+4.7727%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

qw4990 · 2026-02-09T08:07:28Z

/ok-to-test

pkg/executor/builder.go

hawkingrei · 2026-02-10T02:00:51Z

/retest

hawkingrei · 2026-02-10T02:03:10Z

pkg/executor/test/planreplayer/plan_replayer_test.go

+	for i := 1; i <= numTables; i++ {
+		tableName := fmt.Sprintf("t_dump_multi_%d", i)
+		require.Contains(t, names, fmt.Sprintf("stats/test.%s.json", tableName))
+		require.Contains(t, names, fmt.Sprintf("schema/test.%s.schema.txt", tableName))


The tests are a bit thin; can we have AI generate some examples with multiple databases?

Added more databases.

guo-shaoge · 2026-02-10T03:42:32Z

pkg/parser/ast/misc.go

+		ctx.WritePlain(")")
+		return nil
+	}
 	if n.Stmt == nil {


question: When will n.Stmt is nil

It seems like we can specify a SQL file, for example: plan replayer dump explain {sql.txt}:

guo-shaoge · 2026-02-10T03:43:20Z

pkg/parser/ast/misc_test.go

+		{"plan replayer dump explain ('SELECT * FROM t1', 'SELECT * FROM t2')",
+			"PLAN REPLAYER DUMP EXPLAIN ('SELECT * FROM t1', 'SELECT * FROM t2')"},
+		{"plan replayer dump explain analyze ('SELECT * FROM t1')",
+			"PLAN REPLAYER DUMP EXPLAIN ANALYZE ('SELECT * FROM t1')"},


Add edge case that with empty and non empty in the stmt list?

I'll error if it's empty. I added an test in TestPlanReplayerDumpMultiple:

guo-shaoge · 2026-02-10T06:18:48Z

/hold

ti-chi-bot · 2026-02-10T06:18:50Z

[LGTM Timeline notifier]

Timeline:

2026-02-10 02:17:01.490163925 +0000 UTC m=+237637.184303765: ☑️ agreed by hawkingrei.
2026-02-10 06:18:48.514536786 +0000 UTC m=+252144.208676626: ☑️ agreed by guo-shaoge.

guo-shaoge · 2026-02-10T06:18:57Z

feel free to unhold if you're ready to merge

qw4990 · 2026-02-10T07:01:38Z

/unhold

qw4990 · 2026-02-10T07:17:38Z

The doc PR: pingcap/docs#22429

D3Hunter

/approve

qw4990 · 2026-02-10T07:45:06Z

/test build

tiprow · 2026-02-10T07:45:38Z

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow

/test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

qw4990 · 2026-02-10T07:50:01Z

/test pull-build-next-gen

tiprow · 2026-02-10T07:50:31Z

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow

/test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

/test pull-build-next-gen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

qw4990 · 2026-02-10T09:40:07Z

/test check-dev2
/test pull-br-integration-test

tiprow · 2026-02-10T09:40:38Z

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow

/test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

/test check-dev2
/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

qw4990 · 2026-02-10T09:52:21Z

/test check-dev2

tiprow · 2026-02-10T09:52:44Z

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow

/test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot · 2026-02-11T01:55:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, guo-shaoge, hawkingrei, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [D3Hunter,guo-shaoge,hawkingrei]
~~pkg/domain/OWNERS~~ [D3Hunter]
~~pkg/parser/OWNERS~~ [D3Hunter,yudongusa]
~~pkg/planner/OWNERS~~ [guo-shaoge,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

qw4990 · 2026-02-11T06:03:09Z

/test pull-integration-realcluster-test-next-gen

tiprow · 2026-02-11T06:03:32Z

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow

/test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

/test pull-integration-realcluster-test-next-gen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

qw4990 added 2 commits February 9, 2026 15:03

fixup

34e26d2

fixup

2fa7233

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked labels Feb 9, 2026

ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/planner SIG: Planner labels Feb 9, 2026

ti-chi-bot bot removed the do-not-merge/needs-tests-checked label Feb 9, 2026

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Feb 9, 2026

pantheon-ai bot reviewed Feb 9, 2026

View reviewed changes

pkg/executor/builder.go Show resolved Hide resolved

hawkingrei reviewed Feb 10, 2026

View reviewed changes

hawkingrei approved these changes Feb 10, 2026

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 10, 2026

guo-shaoge reviewed Feb 10, 2026

View reviewed changes

guo-shaoge approved these changes Feb 10, 2026

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 10, 2026

ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2026

fixup

dacfc2d

ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2026

qw4990 mentioned this pull request Feb 10, 2026

planner: Plan Replayer supports dumping multiple statement at once pingcap/docs#22429

Open

14 tasks

D3Hunter reviewed Feb 10, 2026

View reviewed changes

fixup

090cdf4

fixup

0b80fb7

yudongusa approved these changes Feb 11, 2026

View reviewed changes

ti-chi-bot bot added the approved label Feb 11, 2026

ti-chi-bot bot merged commit 7f4c215 into pingcap:master Feb 11, 2026
32 checks passed

Comments

Conversation

qw4990 commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What changed and how does it work?

Parser

Planner/Executor

Dump Output

Example

Check List

Release note

Uh oh!

pantheon-ai bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tiprow bot commented Feb 9, 2026

Uh oh!

qw4990 commented Feb 9, 2026

Uh oh!

pantheon-ai bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Review Complete

Review Summary

Key Findings

Overall Assessment

Uh oh!

qw4990 commented Feb 9, 2026

Uh oh!

tiprow bot commented Feb 9, 2026

Uh oh!

codecov bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

qw4990 commented Feb 9, 2026

Uh oh!

Uh oh!

hawkingrei commented Feb 10, 2026

Uh oh!

hawkingrei Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

qw4990 Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

guo-shaoge Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

qw4990 Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

guo-shaoge Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

qw4990 Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

guo-shaoge commented Feb 10, 2026

Uh oh!

ti-chi-bot bot commented Feb 10, 2026

[LGTM Timeline notifier]

Uh oh!

guo-shaoge commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qw4990 commented Feb 10, 2026

Uh oh!

qw4990 commented Feb 10, 2026

Uh oh!

D3Hunter left a comment

Choose a reason for hiding this comment

Uh oh!

qw4990 commented Feb 10, 2026

Uh oh!

tiprow bot commented Feb 10, 2026

Uh oh!

qw4990 commented Feb 10, 2026

Uh oh!

tiprow bot commented Feb 10, 2026

qw4990 commented Feb 9, 2026 •

edited

Loading

pantheon-ai bot commented Feb 9, 2026 •

edited

Loading

pantheon-ai bot commented Feb 9, 2026 •

edited

Loading

codecov bot commented Feb 9, 2026 •

edited

Loading

guo-shaoge commented Feb 10, 2026 •

edited

Loading