pkg/ddl: loose the pre-check for temporary table.#65598
pkg/ddl: loose the pre-check for temporary table.#65598bb7133 wants to merge 1 commit intopingcap:masterfrom
Conversation
Now it is allowed to create a temp table for tables with 'SHARD_ROW_ID_BITS' and 'PRE_SPLIT_REGIONS', those 2 attributes will be just ignored.
|
@bb7133: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #65598 +/- ##
================================================
+ Coverage 77.8487% 79.3403% +1.4915%
================================================
Files 1978 1901 -77
Lines 542181 529853 -12328
================================================
- Hits 422081 420387 -1694
+ Misses 118441 108011 -10430
+ Partials 1659 1455 -204
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@bb7133: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AilinKid, tiancaiamao The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #65430
Problem Summary: The current behavior(reporting errors with those attributes) is actually by-design, but now we think it's meaningful to create a temporary table for tables with
SHARD_ROW_ID_BITSandPRE_SPLIT_REGIONS, as long as we ignore those 2 attributes for the temporary table.What changed and how does it work?
Allow
CREATE TEMPORARY TABLE ... LIKEto ignoreSHARD_ROW_ID_BITSandPRE_SPLIT_REGIONSinherited from the source table. The preprocessor no longer rejects temp table creation when the referenced table uses sharding bits, and the table-info clone clears shard/pre-split settings for temporary tables.Updated serial DDL tests to expect success and verify
SHOW CREATE TABLEfor the temporary table omits these options.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.