types: print argument as hex literal if non-printable (#65384)#65510
types: print argument as hex literal if non-printable (#65384)#65510ti-chi-bot wants to merge 2 commits intopingcap:release-8.5from
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
@dveeden This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #65510 +/- ##
================================================
Coverage ? 71.1183%
================================================
Files ? 1681
Lines ? 469228
Branches ? 0
================================================
Hits ? 333707
Misses ? 113739
Partials ? 21782
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/unhold |
|
/retest |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: qw4990 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #65384
What problem does this PR solve?
Issue Number: close #65383
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
Alternatives
< 0x20(non printable ASCII and0x7f(DEL). However that doesn't check any multi-byte non-BMP runes (e.g.\u2060(SWJ).datum.GetStringWithCheck(). Probably heavier and might only check if a string is valid, not if it is printable as well.