expression: Vectorized versions of new UUID functions by dveeden · Pull Request #65301 · pingcap/tidb

dveeden · 2025-12-27T08:03:05Z

What problem does this PR solve?

Issue Number: ref #61982

Problem Summary:

What changed and how does it work?

Follow-up for #65007 (comment)

Add vectorized versions of these:

UUID_V4()
UUID_V7()
UUID_VERSION()
UUID_TIMESTAMP()

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

- `UUID_V4()` - `UUID_V7()` - `UUID_VERSION()` - `UUID_TIMESTAMP()`

dveeden · 2025-12-27T08:03:23Z

/ok-to-test

tiprow · 2025-12-27T08:03:25Z

Hi @dveeden. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2025-12-27T08:26:00Z

Codecov Report

❌ Patch coverage is 77.77778% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.3446%. Comparing base (4c2dda7) to head (18af45f).
⚠️ Report is 34 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #65301        +/-   ##
================================================
+ Coverage   70.7739%   77.3446%   +6.5707%     
================================================
  Files          1902       1988        +86     
  Lines        518934     552581     +33647     
================================================
+ Hits         367270     427392     +60122     
+ Misses       127117     123340      -3777     
+ Partials      24547       1849     -22698

Flag	Coverage Δ
integration	`41.2913% <70.5263%> (-6.8876%)`	⬇️
unit	`76.9799% <46.4646%> (+11.2963%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`56.6191% <ø> (+3.7490%)`	⬆️
parser	`∅ <ø> (∅)`
br	`50.2776% <ø> (-8.0162%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

zanmato1984

We may need to add some test cases.

dveeden · 2025-12-29T11:34:19Z

/retest

dveeden · 2025-12-29T13:23:07Z

/retest

dveeden · 2025-12-29T13:50:07Z

/retest

hawkingrei · 2025-12-29T14:01:03Z

/retest

dveeden · 2025-12-29T15:33:30Z

/retest

pkg/expression/builtin_miscellaneous_vec.go

pkg/expression/builtin_miscellaneous_test.go

zanmato1984 · 2025-12-30T10:54:01Z

pkg/expression/builtin_miscellaneous_test.go

 	require.NoError(t, err)
 }

+func TestUUIDv4(t *testing.T) {


I think the TestUUID/UUIDv4/v7 test family can be generalized to a common function like testUUIDWithVersion(t *testing.T, fn string, ver uuid.Version) to minimize code duplication?

I've done this in 18af45f

Co-authored-by: Rossi Sun <zanmato1984@gmail.com>

tests/integrationtest/r/expression/uuid.result

zanmato1984

LGTM

pkg/expression/builtin_miscellaneous_vec.go

windtalker

lgtm

ti-chi-bot · 2025-12-31T08:18:45Z

[LGTM Timeline notifier]

Timeline:

2025-12-31 01:09:16.365921995 +0000 UTC m=+146112.184230427: ☑️ agreed by zanmato1984.
2025-12-31 08:18:44.407846157 +0000 UTC m=+171880.226154639: ☑️ agreed by windtalker.

bb7133

LGTM

ti-chi-bot · 2026-01-06T18:35:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, hawkingrei, windtalker, XuHuaiyu, zanmato1984

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [XuHuaiyu,bb7133,hawkingrei,windtalker,zanmato1984]
~~pkg/expression/OWNERS~~ [XuHuaiyu,windtalker,zanmato1984]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dveeden · 2026-01-06T19:11:44Z

/retest

ref pingcap#61982

expression: Vecotorized versions of new UUID functions

d9c9b9d

- `UUID_V4()` - `UUID_V7()` - `UUID_VERSION()` - `UUID_TIMESTAMP()`

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 27, 2025

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Dec 27, 2025

dveeden changed the title ~~expression: Vecotorized versions of new UUID functions~~ expression: Vectorized versions of new UUID functions Dec 27, 2025

dveeden requested review from GMHDBJD, windtalker and zanmato1984 December 28, 2025 12:28

zanmato1984 reviewed Dec 29, 2025

View reviewed changes

Add more tests

bd5ecca

ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 29, 2025

Upgrade google/uuid

578d8b3

Update DEPS.bzl for google/uuid

7e282a2

dveeden requested a review from hawkingrei December 29, 2025 13:53

Run go mod tidy

bd557d4

zanmato1984 reviewed Dec 30, 2025

View reviewed changes

pkg/expression/builtin_miscellaneous_vec.go Outdated Show resolved Hide resolved

pkg/expression/builtin_miscellaneous_vec.go Outdated Show resolved Hide resolved

dveeden added 2 commits December 30, 2025 08:55

Various updates

82dcd94

Merge remote-tracking branch 'upstream/master' into uuid_vec

f4e2b3e

zanmato1984 reviewed Dec 30, 2025

View reviewed changes

dveeden and others added 2 commits December 30, 2025 12:08

Apply suggestions from code review

6717040

Co-authored-by: Rossi Sun <zanmato1984@gmail.com>

Update based on code review

560f566

zanmato1984 reviewed Dec 30, 2025

View reviewed changes

tests/integrationtest/r/expression/uuid.result Outdated Show resolved Hide resolved

dveeden added 2 commits December 30, 2025 14:07

Update expression/uuid result

b98782a

Unify UUID testing

18af45f

This was referenced Dec 30, 2025

Pushdown for UUID_VERSION() and UUID_TIMESTAMP() tikv/tikv#19253

Closed

Pushdown for UUID_VERSION() and UUID_TIMESTAMP() #65348

Closed

expression: UUID_VERSION() and UUID_TIMESTAMP() pushdown to TiKV #65349

Merged

zanmato1984 approved these changes Dec 31, 2025

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 31, 2025

windtalker reviewed Dec 31, 2025

View reviewed changes

pkg/expression/builtin_miscellaneous_vec.go Show resolved Hide resolved

windtalker approved these changes Dec 31, 2025

View reviewed changes

dveeden mentioned this pull request Dec 31, 2025

Precise space reservation for UUID generation #65364

Closed

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 31, 2025

dveeden assigned bb7133 and XuHuaiyu Dec 31, 2025

hawkingrei approved these changes Dec 31, 2025

View reviewed changes

XuHuaiyu approved these changes Jan 6, 2026

View reviewed changes

dveeden unassigned XuHuaiyu Jan 6, 2026

bb7133 approved these changes Jan 6, 2026

View reviewed changes

ti-chi-bot bot added the approved label Jan 6, 2026

ti-chi-bot bot merged commit bedae51 into pingcap:master Jan 6, 2026
29 checks passed

dveeden mentioned this pull request Jan 7, 2026

Add new UUID functions pingcap/docs#22234

Open

14 tasks

Reminiscent pushed a commit to Reminiscent/tidb that referenced this pull request Jan 14, 2026

expression: Vectorized versions of new UUID functions (pingcap#65301)

570b4d8

ref pingcap#61982

Comments

Conversation

dveeden commented Dec 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

dveeden commented Dec 27, 2025

Uh oh!

tiprow bot commented Dec 27, 2025

Uh oh!

codecov bot commented Dec 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zanmato1984 left a comment

Choose a reason for hiding this comment

Uh oh!

dveeden commented Dec 29, 2025

Uh oh!

dveeden commented Dec 29, 2025

Uh oh!

dveeden commented Dec 29, 2025

Uh oh!

hawkingrei commented Dec 29, 2025

Uh oh!

dveeden commented Dec 29, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zanmato1984 Dec 30, 2025

Choose a reason for hiding this comment

Uh oh!

dveeden Dec 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zanmato1984 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

windtalker left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot bot commented Dec 31, 2025

[LGTM Timeline notifier]

Uh oh!

bb7133 left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot bot commented Jan 6, 2026

Uh oh!

dveeden commented Jan 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dveeden commented Dec 27, 2025 •

edited

Loading

codecov bot commented Dec 27, 2025 •

edited

Loading