sessionctx: Increase max value for innodb_lock_wait_timeout#65153
Merged
ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom Dec 22, 2025
Merged
sessionctx: Increase max value for innodb_lock_wait_timeout#65153ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom
ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom
Conversation
ti-chi-bot
bot
added
do-not-merge/needs-triage-completed
release-note-none
|
Hi @dveeden. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
lance6716
approved these changes
Dec 21, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #65153 +/- ##
================================================
- Coverage 70.7525% 68.6928% -2.0597%
================================================
Files 1895 1873 -22
Lines 518076 510928 -7148
================================================
- Hits 366552 350971 -15581
- Misses 127017 137608 +10591
+ Partials 24507 22349 -2158
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
yudongusa
approved these changes
Dec 22, 2025
yudongusa
left a comment
yudongusa
left a comment
There was a problem hiding this comment.
Please open a document PR on this.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, mjonss, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
14 tasks
Contributor
Author
|
dveeden
added a commit
to dveeden/hibernate-orm
that referenced
this pull request
Feb 13, 2026
- In MySQL `innodb_lock_wait_timeout` can be between 1 and 1073741824 - In TiDB v8.5.5 `innodb_lock_wait_timeout` can be between 1 and 3600 - In TiDB maste `innodb_lock_wait_timeout` can be between 1 and 1073741824 This PR adds an argument to `ConnectionLockTimeoutStrategyImpl` to set the limit of the `innodb_lock_wait_timeout` so it can be re-used by TiDB v8.5.5 References: - https://dev.mysql.com/doc/refman/8.4/en/innodb-parameters.html#sysvar_innodb_lock_wait_timeout - https://docs.pingcap.com/tidb/stable/system-variables/#innodb_lock_wait_timeout - pingcap/tidb#65153
dveeden
added a commit
to dveeden/hibernate-orm
that referenced
this pull request
Feb 16, 2026
- In MySQL `innodb_lock_wait_timeout` can be between 1 and 1073741824 - In TiDB v8.5.5 `innodb_lock_wait_timeout` can be between 1 and 3600 - In TiDB maste `innodb_lock_wait_timeout` can be between 1 and 1073741824 This PR adds an argument to `ConnectionLockTimeoutStrategyImpl` to set the limit of the `innodb_lock_wait_timeout` so it can be re-used by TiDB v8.5.5 References: - https://dev.mysql.com/doc/refman/8.4/en/innodb-parameters.html#sysvar_innodb_lock_wait_timeout - https://docs.pingcap.com/tidb/stable/system-variables/#innodb_lock_wait_timeout - pingcap/tidb#65153
dveeden
added a commit
to dveeden/hibernate-orm
that referenced
this pull request
Feb 18, 2026
- In MySQL `innodb_lock_wait_timeout` can be between 1 and 1073741824 - In TiDB v8.5.5 `innodb_lock_wait_timeout` can be between 1 and 3600 - In TiDB maste `innodb_lock_wait_timeout` can be between 1 and 1073741824 This PR adds an argument to `ConnectionLockTimeoutStrategyImpl` to set the limit of the `innodb_lock_wait_timeout` so it can be re-used by TiDB v8.5.5 References: - https://dev.mysql.com/doc/refman/8.4/en/innodb-parameters.html#sysvar_innodb_lock_wait_timeout - https://docs.pingcap.com/tidb/stable/system-variables/#innodb_lock_wait_timeout - pingcap/tidb#65153 Co-authored-by: Christian Beikov <christian.beikov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #65152
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.