optimizer: postpone AdviseWarmup after processing binding#60236
optimizer: postpone AdviseWarmup after processing binding#60236ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
Conversation
Signed-off-by: lance6716 <lance6716@gmail.com>
|
Hi @lance6716. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ekexium
left a comment
There was a problem hiding this comment.
The test LGTM. I'm not familiar with the binding. Please also request reviews from optimizer experts
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #60236 +/- ##
================================================
+ Coverage 73.1715% 73.5522% +0.3807%
================================================
Files 1708 1708
Lines 471864 471904 +40
================================================
+ Hits 345270 347096 +1826
+ Misses 105371 103589 -1782
+ Partials 21223 21219 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekexium, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #60231 close #60229
Problem Summary:
What changed and how does it work?
#34702 says AdviceWarmUp in only an optimization, won't affect the correctness.
Because
in order to let pipeline DML flag in binding really take effect, I postpone AdviceWarmUp.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.