Skip to content

optimizer: postpone AdviseWarmup after processing binding#60236

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
lance6716:fix60231
Mar 24, 2025
Merged

optimizer: postpone AdviseWarmup after processing binding#60236
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
lance6716:fix60231

Conversation

@lance6716
Copy link
Contributor

@lance6716 lance6716 commented Mar 24, 2025

What problem does this PR solve?

Issue Number: close #60231 close #60229

Problem Summary:

What changed and how does it work?

#34702 says AdviceWarmUp in only an optimization, won't affect the correctness.

Because

  1. AdviceWarmUp will use pipeline DML flag when creating TS future
  2. binding is processed after AdviceWarmUp
  3. binding may change the pipeline DML flag

in order to let pipeline DML flag in binding really take effect, I postpone AdviceWarmUp.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 24, 2025
@tiprow
Copy link

tiprow bot commented Mar 24, 2025

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: lance6716 <lance6716@gmail.com>
Copy link
Member

@ekexium ekexium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test LGTM. I'm not familiar with the binding. Please also request reviews from optimizer experts

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 24, 2025
@codecov
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.5522%. Comparing base (6dd95c9) to head (b9e1304).
Report is 1 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #60236        +/-   ##
================================================
+ Coverage   73.1715%   73.5522%   +0.3807%     
================================================
  Files          1708       1708                
  Lines        471864     471904        +40     
================================================
+ Hits         345270     347096      +1826     
+ Misses       105371     103589      -1782     
+ Partials      21223      21219         -4     
Flag Coverage Δ
integration 42.7341% <0.0000%> (?)
unit 72.3399% <0.0000%> (-0.0323%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 47.2048% <ø> (+0.0361%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekexium, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 24, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 24, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-24 08:57:03.931396592 +0000 UTC m=+864317.615632688: ☑️ agreed by ekexium.
  • 2025-03-24 09:31:17.537139324 +0000 UTC m=+866371.221375422: ☑️ agreed by qw4990.

@ti-chi-bot ti-chi-bot bot merged commit 752f18b into pingcap:master Mar 24, 2025
22 of 24 checks passed
lance6716 added a commit to lance6716/tidb that referenced this pull request Mar 25, 2025
disksing pushed a commit to oh-my-tidb/tidb that referenced this pull request Mar 27, 2025
zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

create binding for /*+ SET_VAR(tidb_dml_type=bulk) */ does not work the hint /*+ SET_VAR(tidb_dml_type = 'bulk')*/ is not compatible with SQL binding

3 participants