Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br/stream: allow pitr to create oversized indices #58433

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

YuJuncen
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #58430

Problem Summary:
During restoring, the internal config of BR wasn't updated.
It may reject all indices longer than the default config (3072) though the target cluster modified this config.

What changed and how does it work?

This updates the TiDB config of the BR internal TiDB instance during restoring incremental data.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fixed a bug that caused cannot restore index created during log backup if it is longer than `3072`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 20, 2024
Copy link

tiprow bot commented Dec 20, 2024

Hi @YuJuncen. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@YuJuncen YuJuncen changed the title allow pitr to create oversized indices br/stream: allow pitr to create oversized indices Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.6051%. Comparing base (acba0cd) to head (0a2ec18).
Report is 4 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58433        +/-   ##
================================================
+ Coverage   73.5696%   73.6051%   +0.0354%     
================================================
  Files          1681       1762        +81     
  Lines        463846     540204     +76358     
================================================
+ Hits         341250     397618     +56368     
- Misses       101779     118823     +17044     
- Partials      20817      23763      +2946     
Flag Coverage Δ
integration 46.2636% <100.0000%> (?)
unit 72.3054% <0.0000%> (-0.0316%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 56.6989% <100.0000%> (+10.8976%) ⬆️

@YuJuncen
Copy link
Contributor Author

/test pull-br-integration-test

1 similar comment
@YuJuncen
Copy link
Contributor Author

/test pull-br-integration-test

Copy link

tiprow bot commented Dec 20, 2024

@YuJuncen: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented Dec 20, 2024

@YuJuncen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-integration-e2e-test 0a2ec18 link true /test pull-integration-e2e-test
idc-jenkins-ci-tidb/mysql-test 0a2ec18 link true /test mysql-test
pull-br-integration-test 0a2ec18 link true /test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@@ -1321,6 +1321,9 @@ func restoreStream(
ctx, cancelFn := context.WithCancel(c)
defer cancelFn()

restoreCfg := enableTiDBConfig()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe let's put a comment here for what it's used for?

Copy link

ti-chi-bot bot commented Dec 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Tristan1900
Once this PR has been reviewed and has the lgtm label, please ask for approval from yujuncen, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Dec 21, 2024

@Tristan1900: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PiTR: cannot restore index created during log backup if it is longer than 3072
2 participants