Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EmbedResponse type, regenerate core for 2024-10 #83

Merged

Conversation

austin-denoble
Copy link
Contributor

@austin-denoble austin-denoble commented Oct 22, 2024

Problem

There have been a few small PRs that have gone into the apis repo that we need to regenerate code for:

We're also returning the generated EmbeddingsList type for the Embed method rather than a custom type like we're doing elsewhere.

Solution

  • Add new EmbedResponse, and Embedding types and return from Embed. Add doc comments.
  • Regenerate core SDK code from 2024-10

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Make sure CI is successful.

@austin-denoble austin-denoble changed the base branch from main to release-candidate/2024-10 October 22, 2024 18:45
@austin-denoble austin-denoble marked this pull request as ready for review October 22, 2024 18:49
Copy link
Contributor

@aulorbe aulorbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt

@austin-denoble austin-denoble merged commit 3ee2d73 into release-candidate/2024-10 Oct 22, 2024
2 checks passed
@austin-denoble austin-denoble deleted the adenoble/regenerate-code-fix-type branch October 22, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants