Refactor /codegen/build-clients.sh to support new apis structure, regenerate for 2024-10
#76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re for the upcoming API version, specifically inference is its own module, and db_control/db_data split control and data plane, rename and update exports and imports
austin-denoble
commented
Sep 14, 2024
| pull_request: | ||
| branches: | ||
| - main | ||
| pull_request: {} |
There was a problem hiding this comment.
ci workflow wasn't running because we only run against main and I'm working againrelease-candidate/2024-10 here.
haruska
approved these changes
Sep 16, 2024
austin-denoble
deleted the
adenoble/refactor-code-generation-regenerate-2024-10
branch
austin-denoble
added a commit
that referenced
this pull request
Sep 19, 2024
… regenerate for `2024-10` (#76) ## Problem The upstream `/apis` submodule has undergone some changes since we last regenerated the client core. Our `/codegen/build-clients.sh` script no longer handles the new module naming or structure properly. Additionally, we want to regenerate off the upcoming API version so we can pull in changes for things like Rerank. This PR is **merging to a release candidate (RC) branch: `release-candidate/2024-10`**. We will track upcoming major version changes in this branch and use it for releasing dev builds. ## Solution - Refactor `codegen/build-clients.sh` script to support the newer structure for the upcoming API version, specifically `inference` is its own module, and `db_control`/`db_data` as separate modules. - Update imports and exports for `control` -> `db_control`, and `control` -> `inference` for the `Embed()` method on `InferenceService`. We made the decision to have `InferenceService` as its own module inside `Client` because of the split in the API spec, so this was fairly easy to refactor around here. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [X] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here) ## Test Plan The code changes under `/internal/gen/*` are all from running the new `/codegen/build-clients.sh` script. I changed files in the submodule for `apis` manually for generating, but it aligns with this PR: pinecone-io/apis#138 Make sure CI build + tests pass for the new core stuff here.
austin-denoble
added a commit
that referenced
this pull request
Sep 20, 2024
… regenerate for `2024-10` (#76) ## Problem The upstream `/apis` submodule has undergone some changes since we last regenerated the client core. Our `/codegen/build-clients.sh` script no longer handles the new module naming or structure properly. Additionally, we want to regenerate off the upcoming API version so we can pull in changes for things like Rerank. This PR is **merging to a release candidate (RC) branch: `release-candidate/2024-10`**. We will track upcoming major version changes in this branch and use it for releasing dev builds. ## Solution - Refactor `codegen/build-clients.sh` script to support the newer structure for the upcoming API version, specifically `inference` is its own module, and `db_control`/`db_data` as separate modules. - Update imports and exports for `control` -> `db_control`, and `control` -> `inference` for the `Embed()` method on `InferenceService`. We made the decision to have `InferenceService` as its own module inside `Client` because of the split in the API spec, so this was fairly easy to refactor around here. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [X] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here) ## Test Plan The code changes under `/internal/gen/*` are all from running the new `/codegen/build-clients.sh` script. I changed files in the submodule for `apis` manually for generating, but it aligns with this PR: pinecone-io/apis#138 Make sure CI build + tests pass for the new core stuff here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The upstream
/apissubmodule has undergone some changes since we last regenerated the client core. Our/codegen/build-clients.shscript no longer handles the new module naming or structure properly.Additionally, we want to regenerate off the upcoming API version so we can pull in changes for things like Rerank.
This PR is merging to a release candidate (RC) branch:
release-candidate/2024-10. We will track upcoming major version changes in this branch and use it for releasing dev builds.Solution
codegen/build-clients.shscript to support the newer structure for the upcoming API version, specificallyinferenceis its own module, anddb_control/db_dataas separate modules.control->db_control, andcontrol->inferencefor theEmbed()method onInferenceService.We made the decision to have
InferenceServiceas its own module insideClientbecause of the split in the API spec, so this was fairly easy to refactor around here.Type of Change
Test Plan
The code changes under
/internal/gen/*are all from running the new/codegen/build-clients.shscript. I changed files in the submodule forapismanually for generating, but it aligns with this PR: https://github.com/pinecone-io/apis/pull/138Make sure CI build + tests pass for the new core stuff here.