Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Management Plane Alpha: Project and API Key Management #15

Merged
merged 14 commits into from
Apr 9, 2024

Conversation

haruska
Copy link
Contributor

@haruska haruska commented Mar 19, 2024

Adds the management plane alpha API to the Go SDK. Implementation is similar to the control plane client currently in stable.

This initial alpha release provides robust support for managing projects and their associated API keys directly through the Go client library.

New Features

Project Management

  • CreateProject: Allows users to create new projects, specifying project names.
  • ListProjects: Enables listing all projects available to the user.
  • FetchProject: Retrieves details for a specific project by its ID.
  • DeleteProject: Removes a project identified by its ID.

API Key Management

  • CreateApiKey: Supports creating new API keys within a specified project, including setting names for easy identification.
  • ListApiKeys: Lists all API keys associated with a given project, enhancing manageability and oversight.
  • FetchApiKey: Simplified to fetch details of an API key using its ID only, removing the need for projectId in the request.
  • DeleteApiKey: Allows for the deletion of specific API keys by their ID, completing the set of CRUD operations for API key management.

@haruska haruska changed the base branch from main to alpha March 19, 2024 22:25
@haruska haruska marked this pull request as ready for review April 2, 2024 21:24
@haruska haruska changed the title Mgmt plane alpha Management Plane Alpha: Project and API Key Management Apr 2, 2024
Copy link
Contributor

@austin-denoble austin-denoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. straightforward and easy to understand, I've got some questions and nits but nothing blocking. Thanks a bunch for adding in docstring comments for the management plane stuff as a part of implementation. 🥳

pinecone/management_client.go Show resolved Hide resolved
pinecone/management_client.go Outdated Show resolved Hide resolved
pinecone/management_client.go Outdated Show resolved Hide resolved
pinecone/management_client.go Show resolved Hide resolved
pinecone/management_client.go Outdated Show resolved Hide resolved
Copy link
Contributor

@aulorbe aulorbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some Qs for my understanding and learning :)

Copy link
Contributor

@ssmith-pc ssmith-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will echo others' feedback that it's great how well written this is. Added a few comments, don't think it's anything blocking

pinecone/management_client.go Outdated Show resolved Hide resolved
pinecone/management_client.go Outdated Show resolved Hide resolved
pinecone/management_client.go Outdated Show resolved Hide resolved
pinecone/management_client.go Outdated Show resolved Hide resolved
pinecone/management_client.go Show resolved Hide resolved
pinecone/management_client_test.go Outdated Show resolved Hide resolved
@haruska haruska merged commit 22cce8b into alpha Apr 9, 2024
3 checks passed
@haruska haruska deleted the mgmt_plane_alpha branch April 9, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants