Add control plane to SDK #14
Conversation
Wrap the generated code for CRUDL operations on Indexes.
Adds CRUDL operations available on Collections in the SDK. Provides a thin wrapper around the generated code.
haruska
force-pushed
the
add_control_plane
branch
2 times, most recently
from
348ff5d to
c65c140
Compare
Testing still requires hitting Pinecone with known indexes created. However, this is simplified to just need the API Key and names of the indexes. The rest is looked up by the control plane calls.
haruska
force-pushed
the
add_control_plane
branch
from
c65c140 to
cb2e9ee
Compare
There was a problem hiding this comment.
Nice work, I think overall this looks good to me. I've left some comments and questions but I don't think there's necessarily anything blocking here. Thanks a lot for getting the testing suite off the ground as part of this work.
I still need to find some time to pull the repo down and get set up to play around locally, but I feel like everything here makes sense.
| "io" | ||
| "net/http" | ||
| ) | ||
|
|
||
| type Client struct { |
There was a problem hiding this comment.
I think probably the Client struct should be lowercase/private client to force people to go through the NewClient constructor method.
There was a problem hiding this comment.
I believe Client must be exported. The fields apiKey and restClient however are not exported. The only real way to get a valid client is through NewClient
This PR adds the Control Plane REST API calls for managing Indexes and Collections.
Similar to the codegen for the Data Plane gRPC calls, this generates code from the OpenAPI Spec for the Control Plane REST calls. These calls are then wrapped in the SDK to reduce the surface area of the SDK to support.