Search notebooks #496
Merged
Search notebooks #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
arjunpatel7
reviewed
Aug 15, 2025
| @@ -0,0 +1,680 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
| @@ -0,0 +1,680 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
| @@ -0,0 +1,680 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
You should mention here that if you do this reranking, the responses might not be ordered on on their lexical relevance along anymore. I.E, it's possible to have an ordering of lexical top to bottom, and that get's a bit muddled after reranking semantically, but relevance is maximized nonetheless.
Reply via ReviewNB
Contributor
|
LGTM, but added some comments that could help clarify |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Added:
Solution
Describe the approach you took. Link to any relevant bugs, issues, docs, or other resources.
Type of Change
Test Plan
Describe specific steps for validating this change.