Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mypy failures #327

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Fix mypy failures #327

merged 1 commit into from
Mar 25, 2024

Conversation

izellevy
Copy link
Collaborator

@izellevy izellevy commented Mar 25, 2024 •
edited
Loading

Problem

New Cohere SDK breaks the mypy checks.

Solution

Pin the cohere SDK version

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Describe specific steps for validating this change.

igiloh-pinecone
igiloh-pinecone approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@igiloh-pinecone igiloh-pinecone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@izellevy izellevy added this pull request to the merge queue Mar 25, 2024
Merged via the queue into pinecone-io:main with commit 7db7737 Mar 25, 2024
7 checks passed
@izellevy izellevy deleted the fix/mypy_checks branch March 25, 2024 19:38
@Anush008 Anush008 mentioned this pull request Mar 26, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igiloh-pinecone igiloh-pinecone igiloh-pinecone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@izellevy @igiloh-pinecone