setting Array as custom
replaces numbers
#113
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug when using the option to set an Array of allowed characters by giving an Array to the
custom
option: it replaces numbers in the string with the allowed characters.Example:
The reason is that the check if the
custom
property is an object also returns true if it is an Array. Because of that a replacement map is set for the Array indizes and 0, 1, … are replaced with the custom allowed characters.This pull requests adds a test and a fix for that by additionally checking if the object is not an Array.
It would be great if you could publish an update to npm with that fix