Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Example was not compatible with new Twig version 3 #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dipohl
Copy link

@dipohl dipohl commented Dec 5, 2023

Under Pico-30: PHP message: PHP Fatal error: Uncaught Twig\Error\SyntaxError: Unexpected token "name" of value "if" ("end of statement block" expected).

@PhrozenByte
Copy link
Collaborator

Thank you for your contribution! 👍 However, that's because the docs reference Pico 2.1, not the dev version of Pico 3.0. See #61, it was fixed there already. Thanks nevertheless!

@dipohl
Copy link
Author

dipohl commented Dec 6, 2023

because the docs reference Pico 2.1, not the dev version of Pico 3.0. See #61, it was fixed there already.

I suppose the updated syntax example will work under both Twig versions, so you can change it anyhow.

As Docs for Pico 3.0 are not shown on the website (at least I didn't see / find it there) I strongly vote for it. Otherwise all users of the new version will get frustrated with the incompatible advice..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants