-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upd: DNSCrypt url fixed. #1111
base: master
Are you sure you want to change the base?
upd: DNSCrypt url fixed. #1111
Conversation
✅ Deploy Preview for pihole-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the right solution is not to link to an archive version of an removed wiki article (which are probably outdated already - last edited 2018/19) but to port the stored (and updated) information to the doc
The Internet archive was inaccessible. So this method didn't make sense anymore. At least for a while. @yubiuser |
#### Alternatives | ||
|
||
* An alternative would be using [DNSCrypt](https://github.com/pi-hole/pi-hole/wiki/DNSCrypt), but this leaves you in a position where you have to trust the [DNSCrypt resolver](https://www.dnscrypt.org/dnscrypt-resolvers.html) since your IP is not anonymized - [unless you configure DNSCrypt to route over Tor](https://github.com/DNSCrypt/dnscrypt-proxy/issues/399#issuecomment-214329222). | ||
* An alternative would be using [DNSCrypt (Archive)](https://web.archive.org/web/20210907204828/https://github.com/pi-hole/pi-hole/wiki/DNSCrypt) or [DNSCrypt-2.0 (Archive)](https://web.archive.org/web/20220617185156/https://github.com/pi-hole/pi-hole/wiki/DNSCrypt-2.0), but this leaves you in a position where you have to trust the [DNSCrypt resolver](https://www.dnscrypt.org/dnscrypt-resolvers.html) since your IP is not anonymized - [unless you configure DNSCrypt to route over Tor](https://github.com/DNSCrypt/dnscrypt-proxy/issues/399#issuecomment-214329222). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original wiki pages were removed because they were really outdated (last update was 2016 or 2018).
Pointing these links to web archive (outdated content) is a bad idea.
I see 3 solutions:
- replace the old links with more current references to
DNSCrypt
(if there are good references); - completely rewrite Alternatives section (maybe using different solutions) and include up-to-date references;
- completely remove the Alternatives section.
Personally I think the last option would be better.
Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
Added Archive.org link to removed link.
How does this PR accomplish the above?:
By giving the right guidance
Link documentation PRs if any are needed to support this PR:
https://github.com/DNSCrypt/dnscrypt-proxy/wiki/Installation-linux
By submitting this pull request, I confirm the following:
git rebase
)